PUBLIC - Liferay Portal Community Edition

Javadoc formatter init crashes with null pointer

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 6.1.1 CE GA2, 6.1.20 EE GA2
  • Fix Version/s: 6.1.X EE, 6.2.0 CE M4
  • Component/s: API, API > Utils
  • Labels:
  • Branch Version/s:
    6.1.x
  • Backported to Branch:
    Committed
  • Story Points:
    2
  • Similar Issues:
    Show 5 results 

Description

The Javadoc formatter is throwing a NullPointerException when run with the init option.

Steps:
1. ant compile compile-test
2. ant format-javadoc -Dlimit=ResourceLocalServiceImpl -Dinit=true

Results in:
...
[java] java.lang.NullPointerException
[java] at com.liferay.portal.tools.JavadocFormatter._wrapText(JavadocFormatter.java:1563)
[java] at com.liferay.portal.tools.JavadocFormatter._getJavaClassComment(JavadocFormatter.java:883)
[java] at com.liferay.portal.tools.JavadocFormatter._updateJavaFromDocument(JavadocFormatter.java:1467)
[java] at com.liferay.portal.tools.JavadocFormatter._format(JavadocFormatter.java:695)
[java] at com.liferay.portal.tools.JavadocFormatter.<init>(JavadocFormatter.java:162)
[java] at com.liferay.portal.tools.JavadocFormatter.main(JavadocFormatter.java:70)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
James Hinkey added a comment -

Corrected faulty logic that was attempting wrapping text comments, even if a comment String was null.

All comments should be should be wrapped to 80 columns if they are non-null, regardless of whether init is flagged.

Tests run...

Test1:
1. ant compile compile-test
2. ant format-javadoc -Dlimit=ResourceLocalServiceImpl
Results:
Javadoc comments were initialized.
For example,
/**
*

  • @param
  • @param
  • @param
  • @param
  • @param
  • @param
  • @param
  • @throws
  • @throws
    */
    public void addModelResources(...)

Note, the update mode was unaffected continuing to work appropriately.

Show
James Hinkey added a comment - Corrected faulty logic that was attempting wrapping text comments, even if a comment String was null. All comments should be should be wrapped to 80 columns if they are non-null, regardless of whether init is flagged. Tests run... Test1: 1. ant compile compile-test 2. ant format-javadoc -Dlimit=ResourceLocalServiceImpl Results: Javadoc comments were initialized. For example, /** * @param @param @param @param @param @param @param @throws @throws */ public void addModelResources(...) Note, the update mode was unaffected continuing to work appropriately.
Hide
Permalink
Michael Saechang added a comment -

Thanks for the testing steps James!

Show
Michael Saechang added a comment - Thanks for the testing steps James!
Hide
Permalink
Serena Song added a comment -

PASSED Manual Testing following the steps in the description.

Reproduced on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 7562514316d904255b6eb95929c076efca2e58c8.

Javadoc formatter init crashes with null pointer.

Fixed on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 5deda67a59216847b4107af178e2b489d3247bd7.
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 8b3d3bc1f59cd7a6efcedc8ac83a779c54b2e211.

No java.lang.NullPointerException displays and build javadoc format successfully.

Show
Serena Song added a comment - PASSED Manual Testing following the steps in the description. Reproduced on: Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 7562514316d904255b6eb95929c076efca2e58c8. Javadoc formatter init crashes with null pointer. Fixed on: Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 5deda67a59216847b4107af178e2b489d3247bd7. Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 8b3d3bc1f59cd7a6efcedc8ac83a779c54b2e211. No java.lang.NullPointerException displays and build javadoc format successfully.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
    Days since last comment:
    14 weeks, 4 days ago