PUBLIC - Liferay Portal Community Edition

com.liferay.portlet.expando.service.impl.ExpandoValueServiceImpl.getJSONData() is buggy and incomplete. Only text expando values can be retrieved by web service

Details

  • Liferay Contributor's Agreement:
    Accept
  • Similar Issues:
    Show 5 results 

Description

this method gets data this way
String data = expandoValueLocalService.getData(
companyId, className, tableName, columnName, classPK,
StringPool.BLANK);
what means that only text type custom fields are supported. If they are arrays, booleans or numbers.
Even more, if the field has no value or a zero length string, it fails.
Even more, local retrieval of non existing columns are returned as null. The remote retrieval of unexisting columns throw an exception

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. LPS-14998 Custom Fileds - Type custom.field.java.lang.String.array is not compatible with type custom.field.java.lang.String

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Contributed Solution - A solution for this feature has been contributed by our community and is awaiting review for submission.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Aniceto P Madrid added a comment -

According to code
public JSONObject getJSONData(
long companyId, String className, String tableName,
String columnName, long classPK)
throws PortalException, SystemException {

ExpandoColumn column = expandoColumnLocalService.getColumn(
companyId, className, tableName, columnName);

if (ExpandoColumnPermissionUtil.contains(
getPermissionChecker(), column, ActionKeys.VIEW)) {

String data = expandoValueLocalService.getData(
companyId, className, tableName, columnName, classPK,
StringPool.BLANK);

if (Validator.isNotNull(data)) {
if (!data.startsWith(StringPool.OPEN_CURLY_BRACE)) {
data = "

{data:".concat(data).concat("}

");
}

return JSONFactoryUtil.createJSONObject(data);
}
else

{ return null; }

}
else

{ return null; }

}

ExpandoColumn info is available. So according to the column type the data could be retrieved accordingly.
The building of the json string should be built accordingly.
And void values should be handled right.

Show
Aniceto P Madrid added a comment - According to code public JSONObject getJSONData( long companyId, String className, String tableName, String columnName, long classPK) throws PortalException, SystemException { ExpandoColumn column = expandoColumnLocalService.getColumn( companyId, className, tableName, columnName); if (ExpandoColumnPermissionUtil.contains( getPermissionChecker(), column, ActionKeys.VIEW)) { String data = expandoValueLocalService.getData( companyId, className, tableName, columnName, classPK, StringPool.BLANK); if (Validator.isNotNull(data)) { if (!data.startsWith(StringPool.OPEN_CURLY_BRACE)) { data = " {data:".concat(data).concat("} "); } return JSONFactoryUtil.createJSONObject(data); } else { return null; } } else { return null; } } ExpandoColumn info is available. So according to the column type the data could be retrieved accordingly. The building of the json string should be built accordingly. And void values should be handled right.
Hide
Permalink
Aniceto P Madrid added a comment -

Added support for all type of expando values

Show
Aniceto P Madrid added a comment - Added support for all type of expando values
Hide
Permalink
Edward Gonzales added a comment -

Hi Aniceto! Thanks for identfying this bug. I noticed that Julio messaged you on github. Let me know if there's anything else I can do to help.

Show
Edward Gonzales added a comment - Hi Aniceto! Thanks for identfying this bug. I noticed that Julio messaged you on github. Let me know if there's anything else I can do to help.
Hide
Permalink
Aniceto P Madrid added a comment -

Hi Edward!
I contributed a solution. It's a pull request. I think all the current expando colum types are supported.The original string format to create a JSONObject was

{data: hshskhkhj}

But that is not safe. Suppose the value contains a comma. An exeption will be thrown. So I pack every data as a string as

{data: "jkljjj"}

.
If the value would be "the tile of the book is "Wonderful"." I don't know if some kind of character escaping would be required before creating the JSONObject.
If the values are type array I have chosen this syntax
{data: [

{value: "jljklj"}

,

{value: "a8adshid"}

]}

JSON lib accepts that string as a valid format and can be retrieved fine.

Finally, I was not sure of how to deal with date values. I decided to return the date.getTime() value

Regards

Show
Aniceto P Madrid added a comment - Hi Edward! I contributed a solution. It's a pull request. I think all the current expando colum types are supported.The original string format to create a JSONObject was {data: hshskhkhj} But that is not safe. Suppose the value contains a comma. An exeption will be thrown. So I pack every data as a string as {data: "jkljjj"} . If the value would be "the tile of the book is "Wonderful"." I don't know if some kind of character escaping would be required before creating the JSONObject. If the values are type array I have chosen this syntax {data: [ {value: "jljklj"} , {value: "a8adshid"} ]} JSON lib accepts that string as a valid format and can be retrieved fine. Finally, I was not sure of how to deal with date values. I decided to return the date.getTime() value Regards
Hide
Permalink
Edward Gonzales added a comment -

Hi Aniceto! Thanks for your contribution. One request: can you test this bug against Master? Let me know if the bug still exist. Thanks for your hard work!

Show
Edward Gonzales added a comment - Hi Aniceto! Thanks for your contribution. One request: can you test this bug against Master? Let me know if the bug still exist. Thanks for your hard work!

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Days since last comment:
    2 weeks, 6 days ago