PUBLIC - Liferay Portal Community Edition

After importing .lar file, asset publisher content does not display

Details

  • Branch Version/s:
    6.1.x
  • Backported to Branch:
    Committed
  • Story Points:
    3
  • Fix Priority:
    5
  • Similar Issues:
    Show 4 results 

Description

Steps to reproduce on a clean bundle:

1. Start with the Guest site.
2. Add a page to the Guest site.
3. Delete the page you added.
4. Add another page "test" to the Guest site.
5. Add a Blogs portlet to the new page.
6. Go to the Configuration screen for the Blogs portlet.
7. Go to the "Scope" tab and choose "Select Page", "Current Page".
8. Add an Asset Publisher portlet to the page.
9. Go to the Configuration screen for the Asset Publisher portlet.
10. Under the "Scope" heading, choose "Select More Than One...".
11. Move all options from Available over to Selected. Note you should have three options.
12. Save the configuration. Note that there are three "Add New" options.
13. In the Dockbar, choose Manage > Site Pages and export the site with the default settings.
14. Navigate to the Sites portlet in the Control panel and add a new site.
15. Choose the "Site Pages" portlet in the Control panel (with the scope set to your new site) and import the LAR exported in step 13.
16. Choose "View Pages" and navigate to the page you created in step 4.

Expected behavior:

You should see three "Add New" options.

Actual behavior:

In trunk, you see two "Add New" options (the page scope is missing). In earlier versions of Liferay, the asset publisher portlet errors out completely and nothing is displayed. In both cases, you will see a stack trace in the console which reads: "com.liferay.portal.NoSuchGroupException: No Group exists with the primary key 0"

Probable cause:

The way we store asset publisher scope groups is with Layout_

{layoutId}, where {layoutId}

is that monotonically increasing number that can double as the friendly URL for the page. When you import a LAR, it re-computes a new value for

{layoutId} for each layout that is imported, but Asset Publisher's portlet preferences aren't updated to know what the new values are. Therefore, even though the appropriate scope groups are created, Asset Publisher will look for the wrong {layoutId}

values because its portlet preferences are not updated.

Additional scenario to test:

based on above steps:

17. create another child page for "test" named "subtest"
18. Delete "subtest" child page and recreate it again
19. repeat steps from 6 to 12, in step 11 and 12, there are 4 options available.

if try to export and import again, either it throws nosuchGroupException or diplays the 4 options with bb, global, subtest, subtest, which is wrong. Should be bb, global, test, subtest

Issue Links

relates

Feature Request - LPS-32674 DefaultScope in AssetPublisher preferences should be as boolean type

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mark Jin added a comment -

PASSED Manual Testing following the steps in the description.

Reproduced on:
Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2.

Tomcat throw error message, Content does not display.

Fixed on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: b08d4ccc77beda2da0c801f9f40bf278c930802a.
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 80a91b2c933dd73de26ca04b9d444f71e7d60b36.

Able to see three button.

Show
Mark Jin added a comment - PASSED Manual Testing following the steps in the description. Reproduced on: Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2. Tomcat throw error message, Content does not display. Fixed on: Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: b08d4ccc77beda2da0c801f9f40bf278c930802a. Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 80a91b2c933dd73de26ca04b9d444f71e7d60b36. Able to see three button.
Hide
Permalink
Sherry Yang added a comment -

The commit should consider another scenario that the asset publisher has multiple layoutIds under scopeIds.

Show
Sherry Yang added a comment - The commit should consider another scenario that the asset publisher has multiple layoutIds under scopeIds.
Hide
Permalink
Mark Jin added a comment - - edited

PASSED Manual Testing following the steps in the description.

Reproduced on:
Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2.

Tomcat throw NoSuchGroupException, I can see 2 options on parent page.
Export and import again, I can see 3 options on child page.

Fixed on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: c2bef0eccc9416751df25051b01dd44ef6403d42.
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 8d358bb65437f26aa117ace71a81f784bbba338f.

Finish step 16, I can see there have 3 options on parent page.
Export and import again, I can see 4 options on child page.

Show
Mark Jin added a comment - - edited PASSED Manual Testing following the steps in the description. Reproduced on: Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2. Tomcat throw NoSuchGroupException, I can see 2 options on parent page. Export and import again, I can see 3 options on child page. Fixed on: Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: c2bef0eccc9416751df25051b01dd44ef6403d42. Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 8d358bb65437f26aa117ace71a81f784bbba338f. Finish step 16, I can see there have 3 options on parent page. Export and import again, I can see 4 options on child page.
Hide
Permalink
Sherry Yang added a comment -

My bad! I put the replicated steps for 6.1.X

Show
Sherry Yang added a comment - My bad! I put the replicated steps for 6.1.X
Hide
Permalink
Mark Jin added a comment -

PASSED Manual Testing following the steps in the description.

Reproduced on:
Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2.

Tomcat throw NoSuchGroupException, I can see 2 options on parent page [site, global].
Export and import again, tomcat cause NoSuchGroupException. I can see 3 options on child page [site, global, test].

Fixed on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: c2bef0eccc9416751df25051b01dd44ef6403d42.
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 8d358bb65437f26aa117ace71a81f784bbba338f.

Finish step 16, I can see there have 3 options on parent page [site, global, test].
Export and import again, I can see 4 options on child page [site, global, test, subtest].

Show
Mark Jin added a comment - PASSED Manual Testing following the steps in the description. Reproduced on: Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2. Tomcat throw NoSuchGroupException, I can see 2 options on parent page [site, global] . Export and import again, tomcat cause NoSuchGroupException. I can see 3 options on child page [site, global, test] . Fixed on: Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: c2bef0eccc9416751df25051b01dd44ef6403d42. Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 8d358bb65437f26aa117ace71a81f784bbba338f. Finish step 16, I can see there have 3 options on parent page [site, global, test] . Export and import again, I can see 4 options on child page [site, global, test, subtest] .
Hide
Permalink
Sherry Yang added a comment - - edited

DefaultScope in Asset publisher is confusing.

In configuration.jsp, the name is defaultScope and the value of it could be true, false, and scopeId. And then in the getGroupIds in AssetPublisherUtil, it is named as defaultScopeId.

In the pull request, I refactored defaultScope to the boolean type and all the scopes changed are set to scopeids.

Show
Sherry Yang added a comment - - edited DefaultScope in Asset publisher is confusing. In configuration.jsp, the name is defaultScope and the value of it could be true, false, and scopeId. And then in the getGroupIds in AssetPublisherUtil, it is named as defaultScopeId. In the pull request, I refactored defaultScope to the boolean type and all the scopes changed are set to scopeids.
Hide
Permalink
Brian Chan added a comment -

From Julio:

this is what happens:

1. I add a page "one" (layoutId = 1)
2. I add another page "two" (layoutId = 2)

3. Now I activate staging (or any export/import process), and 2 new pages are created in stating with this mapping of pages:

page | layoutId (live) | layoutId (staging)
one 1 1
two 2 2

This usually works fine, but the following situation is the one the customer complaint about:

1. I add a page "one" (layoutId = 1)
2 .I add another page "two" (layoutId = 2)
3. I remove the second page
4. I add a third page "three" (layoutId = 3)

5. Now I activate staging, and 2 new pages are created with this mapping of pages:

page | layoutId (live) | layoutId (staging)
one 1 1
three 3 2

In most places, we are assuming that the layoutId may not match when activating staging, but some places (like the one we are fixing in this pull) assumed that the layoutIds would match.

For this reason, we need to add a page and delete it to force the layoutIds not to match between the staging page and the live page.

The current test without my changes passes. However, if you add the lines that you removed before my changes, then all the tests will fail. Those lines are the main goal of the whole test.

I have resent here, let me know if you have any question: https://github.com/brianchandotcom/liferay-portal/pull/8835

Show
Brian Chan added a comment - From Julio: this is what happens: 1. I add a page "one" (layoutId = 1) 2. I add another page "two" (layoutId = 2) 3. Now I activate staging (or any export/import process), and 2 new pages are created in stating with this mapping of pages: page | layoutId (live) | layoutId (staging) one 1 1 two 2 2 This usually works fine, but the following situation is the one the customer complaint about: 1. I add a page "one" (layoutId = 1) 2 .I add another page "two" (layoutId = 2) 3. I remove the second page 4. I add a third page "three" (layoutId = 3) 5. Now I activate staging, and 2 new pages are created with this mapping of pages: page | layoutId (live) | layoutId (staging) one 1 1 three 3 2 In most places, we are assuming that the layoutId may not match when activating staging, but some places (like the one we are fixing in this pull) assumed that the layoutIds would match. For this reason, we need to add a page and delete it to force the layoutIds not to match between the staging page and the live page. The current test without my changes passes. However, if you add the lines that you removed before my changes, then all the tests will fail. Those lines are the main goal of the whole test. I have resent here, let me know if you have any question: https://github.com/brianchandotcom/liferay-portal/pull/8835
Hide
Permalink
Mark Jin added a comment -

PASSED Manual Testing following the steps in the description.

Fixed on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 0205b96f6ab9707a9c9868f4852b42b5983ba711.
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 2ca07788508f9290e8041d9c9729589ab0f6562c.

Finish step 16, I can see there have 3 options on parent page [site, global, test].
Finish all steps I can see 4 options on child page [site, global, test, subtest].

Show
Mark Jin added a comment - PASSED Manual Testing following the steps in the description. Fixed on: Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 0205b96f6ab9707a9c9868f4852b42b5983ba711. Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 2ca07788508f9290e8041d9c9729589ab0f6562c. Finish step 16, I can see there have 3 options on parent page [site, global, test] . Finish all steps I can see 4 options on child page [site, global, test, subtest] .

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
    Days since last comment:
    10 weeks, 6 days ago