PUBLIC - Liferay Portal Community Edition

Ensure URLs for editing models don't get too long

Details

  • Type: Story Story
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: 6.1.1 CE GA2, 6.1.20 EE GA2
  • Fix Version/s: 6.2.0 CE M3
  • Component/s: WCM
  • Labels:
  • Similar Issues:
    Show 5 results 

Description

The pattern:

<portlet:actionURL name="doSomething" var="doSomethingURL">
<portlet:param name="mvcPath" value="..." />
<portlet:param name="redirect" value="<%= redirect %>" />
<portlet:param name="backURL" value="<%= backURL %>" />
</portlet:actionURL>

<aui:form action="<%= doSomethingURL %>">

May break if redirect and backURL point to long urls, thus making doSomethingURL too long.

The better pattern is:

<portlet:actionURL name="doSomething" var="doSomethingURL" />

<aui:form action="<%= doSomethingURL %>">
<aui:input name="redirect" type="hidden" value="<%= redirect %>" />
<aui:input name="backURL" type="hidden" value="<%= backURL %>" />

That way, the url doSomethingURL never gets too long.

Issue Links

causes

Bug - A problem which impairs or prevents the functions of the product. LPS-32215 LiferayWindowState.EXCLUSIVE used instead of WindowState.NORMAL in Private Messaging Portlet

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Regression Bug - Used by Liferay QA to indicate an issue discovered during regression testing SOS-1363 Private Messaging displays improperly after sending a new message

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Josef Šustáček added a comment -

This causes problems, when you use the form URL to be different portlet (like <liferay-portlet:actionURL portletName="<%= PortletKeys.LAYOUTS_ADMIN %>" var="resetPrototypeURL">) than the one you're currently in. Then hidden params in the form have wrong namespace and never arrive to target portlet's action.

Example:
Dockbar -> html/portlet/dockbarview.jsp, where URL is to 88 (PortletKeys.LAYOUTS_ADMIN), but hidden params have previx _145, since you're in a Dockbar portlet.

I guess the same issue will appear on many places in portal, where you use <liferay-portlet:actionURL /> and send user to some other portlet.

Show
Josef Šustáček added a comment - This causes problems, when you use the form URL to be different portlet (like <liferay-portlet:actionURL portletName="<%= PortletKeys.LAYOUTS_ADMIN %>" var="resetPrototypeURL">) than the one you're currently in. Then hidden params in the form have wrong namespace and never arrive to target portlet's action. Example: Dockbar -> html/portlet/dockbarview.jsp, where URL is to 88 (PortletKeys.LAYOUTS_ADMIN), but hidden params have previx _145, since you're in a Dockbar portlet. I guess the same issue will appear on many places in portal, where you use <liferay-portlet:actionURL /> and send user to some other portlet.
Hide
Permalink
Josef Šustáček added a comment -

Observed end-user behavior in the Dockbar, after you click Reset to reset the site status to be the same as linked Site Template is that nothing happens, browsers URL is the action URL (redirect param is also hidden one with different prefix), site template is not merged.

Show
Josef Šustáček added a comment - Observed end-user behavior in the Dockbar, after you click Reset to reset the site status to be the same as linked Site Template is that nothing happens, browsers URL is the action URL ( redirect param is also hidden one with different prefix), site template is not merged.
Hide
Permalink
Michael Saechang added a comment -

Committed on:
Portal 6.2.x GIT ID: 70064815ffa7d2b6bc4aeafbe22470f3a6f46b0c.

Show
Michael Saechang added a comment - Committed on: Portal 6.2.x GIT ID: 70064815ffa7d2b6bc4aeafbe22470f3a6f46b0c.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
    Days since last comment:
    20 weeks ago