PUBLIC - Liferay Portal Community Edition

Categories are assigned duplicative leftcategoryid and rightcategoryid values from preceding categories following removal of vocabularies

Details

  • Branch Version/s:
    6.1.x, 6.0.x
  • Backported to Branch:
    Committed
  • Similar Issues:
    Show 5 results 

Description

ISSUE
In an environment where multiple vocabularies contain categories, deleting a vocabulary will cause the next vocabulary's categories to have duplicate leftcategoryid and rightcategoryids from preceding entries. Essentially, the categoryids are not rebuilt correctly upon deletion of a vocabulary.

STEPS TO REPRODUCE
1. Create vocabulary Vocab1
2. Add categories Cat1, Cat2, Cat3, Cat4, and Cat5 to Vocab1
3. Create vocabulary Vocab2
4. Add categories CatA, CatB, CatC, CatD, and CatE to Vocab2
5. Perform query SELECT * FROM assetcategory; (SEE IMAGE 1)
6. Left and right category ids are in order (for all cases)
7. Delete vocabulary Vocab1
8. Query SELECT * FROM assetcategory; again (SEE IMAGE 2)

EXPECTED RESULTS
The categories' leftcategoryid and rightcategoryid will be rebuilt, and the categories will inherit values that take up the missing numbers left by the deletion in chronological order.

ACTUAL RESULTS
The categories' leftcategoryid and rightcategoryid duplicate as seen in IMAGE 2.

Replicated the issue in TRUNK REV 127687 and BRANCH REV 127687.

Issue Links

relates

Bug - A problem which impairs or prevents the functions of the product. LPS-30909 Categories have wrong leftCategoryId/rightCategoryId values when removing categories with children

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Hugo Huijser added a comment -

Fix consists of two parts:

1. In deleteVocabularyCategories, only delete the the category when it's a root category, when deleting a category the child categories will get deleted also. Therefore, it will try to delete children twice currently.

2. When looping through the categories to delete, call deleteCategory(category.getCategoryId()) instead of deleteCategory(category), when deleting a category, the left and right categoryIds of other categories will change, so for the next in the list, we need to grab the updated category from the database when deleting.

Show
Hugo Huijser added a comment - Fix consists of two parts: 1. In deleteVocabularyCategories, only delete the the category when it's a root category, when deleting a category the child categories will get deleted also. Therefore, it will try to delete children twice currently. 2. When looping through the categories to delete, call deleteCategory(category.getCategoryId()) instead of deleteCategory(category), when deleting a category, the left and right categoryIds of other categories will change, so for the next in the list, we need to grab the updated category from the database when deleting.
Hide
Permalink
Tammy Fong added a comment -

Committed on:
Portal 6.2.x GIT ID: 121dbeffed4c27ebcd922888c15713d9d49452e3.

Show
Tammy Fong added a comment - Committed on: Portal 6.2.x GIT ID: 121dbeffed4c27ebcd922888c15713d9d49452e3.
Hide
Permalink
Luyang Tan added a comment -

PASSED Manual Testing following the steps in the description.

Reproduced on:
Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2.

The categories' leftcategoryid and rightcategoryid duplicate as seen in IMAGE 2.

Fixed on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: dff75a26e7bc006090724d7906dc023e8ad5267d.
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 02fcacb2dd1bf930e32bd320cdc8c6ccb236b5d0.

The categories' leftcategoryid and rightcategoryid is rebuilt, and the categories will inherit values that take up the missing numbers left by the deletion in chronological order.

Show
Luyang Tan added a comment - PASSED Manual Testing following the steps in the description. Reproduced on: Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2. The categories' leftcategoryid and rightcategoryid duplicate as seen in IMAGE 2. Fixed on: Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: dff75a26e7bc006090724d7906dc023e8ad5267d. Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 02fcacb2dd1bf930e32bd320cdc8c6ccb236b5d0. The categories' leftcategoryid and rightcategoryid is rebuilt, and the categories will inherit values that take up the missing numbers left by the deletion in chronological order.
Hide
Permalink
Michael Saechang added a comment -

Thank you Luyang for testing. Closing as 'Fixed'.

Show
Michael Saechang added a comment - Thank you Luyang for testing. Closing as 'Fixed'.
Hide
Permalink
Luyang Tan added a comment -

PASSED Manual Testing following the steps in the description.

Fixed on:
Tomcat 6.0 + MySQL 5. Portal 6.0.x GIT ID: c549b70ebd5b506de593b413bf8a8cdeb4aa2a6a.

The categories' leftcategoryid and rightcategoryid is rebuilt, and the categories will inherit values that take up the missing numbers left by the deletion in chronological order.

Show
Luyang Tan added a comment - PASSED Manual Testing following the steps in the description. Fixed on: Tomcat 6.0 + MySQL 5. Portal 6.0.x GIT ID: c549b70ebd5b506de593b413bf8a8cdeb4aa2a6a. The categories' leftcategoryid and rightcategoryid is rebuilt, and the categories will inherit values that take up the missing numbers left by the deletion in chronological order.
Hide
Permalink
Michael Saechang added a comment -

Thank you Luyang for testing. Closing as 'Fixed'.

Show
Michael Saechang added a comment - Thank you Luyang for testing. Closing as 'Fixed'.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
    Days since last comment:
    31 weeks, 1 day ago