PUBLIC - Liferay Portal Community Edition

There is a possibility for NPE in com.liferay.portal.lar.LayoutExporter

Details

  • Type: Bug Bug
  • Status: In Review In Review
  • Priority: Trivial Trivial
  • Resolution: Unresolved
  • Affects Version/s: 6.1.1 CE GA2, 6.2.0 CE M5
  • Fix Version/s: None
  • Component/s: WCM, WCM > Staging
  • Labels:
    None
  • Similar Issues:
    Show 5 results 

Description

There is a possibility for NPE in com.liferay.portal.lar.LayoutExporter:
Code starts from 388 line:
if ((layoutIds == null) || (layoutIds.length == 0))

{ HERE: javadoc for LayoutLocalServiceUtil.getLayouts says: @return the matching layouts, or <code>null</code> if no matches were found layouts = LayoutLocalServiceUtil.getLayouts(groupId, privateLayout); }

else

{ layouts = LayoutLocalServiceUtil.getLayouts( groupId, privateLayout, layoutIds); }

List<Portlet> portlets = getAlwaysExportablePortlets(companyId);

long plid = LayoutConstants.DEFAULT_PLID;

So, if LayoutLocalServiceUtil.getLayouts will return the null then here (line 400) will be NPE
if (!layouts.isEmpty()) {

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mika Koivisto added a comment -

The javadoc is incorrect it will always return a list even if empty one.

Show
Mika Koivisto added a comment - The javadoc is incorrect it will always return a list even if empty one.
Hide
Permalink
Mika Koivisto added a comment -

Fixed the javadoc.

Show
Mika Koivisto added a comment - Fixed the javadoc.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Days since last comment:
    11 weeks, 3 days ago