PUBLIC - Liferay Portal Community Edition

Wrong attribute URLs for Yahoo when authenticating via OpenId

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 6.1.1 CE GA2, 6.1.20 EE GA2
  • Fix Version/s: 6.1.X EE, 6.2.0 CE M3
  • Component/s: Authentication
  • Labels:
  • Branch Version/s:
    6.1.x
  • Backported to Branch:
    Committed
  • Similar Issues:
    Show 5 results 

Description

  • Reproduction Steps -
    1 - Have a Yahoo account
    2 - On a clean database, using OpenId, log in by typing "yahoo.com" in the field
    3 - You will have to create a user.

The problem with this is that Yahoo fully supports providing all attributes that are needed for Liferay to create an account automatically. This is what you see when you use for example Google.

The issue is probably within com.liferay.portlet.login.action.OpenIdAction, where it attempts to send the following request:
http://schema.openid.net/contact/email
http://schema.openid.net/namePerson/first
http://schema.openid.net/namePerson/last

Whereas Yahoo is expecting the following:
http://axschema.org/namePerson
http://axschema.org/contact/email

When accessing through Yahoo it should automatically create the account.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brian Chan added a comment -

See https://github.com/brianchandotcom/liferay-portal/pull/7561

Show
Brian Chan added a comment - See https://github.com/brianchandotcom/liferay-portal/pull/7561
Hide
Permalink
Serena Song added a comment - - edited

PASSED Manual Testing using the description steps:

Reproduced on:
Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2.

After you login liferay when authenticating via OpenId, you have to create a new account.

Fixed on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 5a342621b1248245755bfc14e349560fd8afe6bc.
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: f7dad6da6a41e571d83d205a08ff6319e3e3950b.

After you login liferay via OpenId, it will redirect to 'New Password' page. Liferay automatically create the account successfully when accessing through Yahoo.

Show
Serena Song added a comment - - edited PASSED Manual Testing using the description steps: Reproduced on: Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2. After you login liferay when authenticating via OpenId, you have to create a new account. Fixed on: Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 5a342621b1248245755bfc14e349560fd8afe6bc. Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: f7dad6da6a41e571d83d205a08ff6319e3e3950b. After you login liferay via OpenId, it will redirect to 'New Password' page. Liferay automatically create the account successfully when accessing through Yahoo.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
    Days since last comment:
    18 weeks ago