PUBLIC - Liferay Portal Community Edition

Missing Indexes in indexes.sql cause upgrades from 5.x to 6.1.20 to take > 65 days

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 6.1.1 CE GA2, 6.1.20 EE GA2
  • Fix Version/s: 6.0.X EE, 6.1.X EE, 6.2.0 CE M2
  • Component/s: Upgrades
  • Labels:
  • Environment:
    MySQL 5.5 + Java 6.0.35 + Tomcat 7.0.25 + very large database
  • Branch Version/s:
    6.1.x, 6.0.x
  • Backported to Branch:
    Committed
  • Similar Issues:
    Show 5 results 

Description

While working on LPP-4193, it was mentioned that I should log an LPS ticket for the general fix.
When working with very large databases, several SQL queries were doing a full-table-scan which was causing upgrades from 5.x to 6.1.20 to take > 65 days.

The fix is to add several table indexes to indexes.sql

In discussion about this, it was mentioned that this perhaps could be categorized as a bug instead of a new feature/improvement because an SQL query that takes over 65 days to complete does not seem like functioning code.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. LPS-30151 VerifyPermission is very slow when there are many layouts

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Bug - A problem which impairs or prevents the functions of the product. LPS-32554 Optimize VerifyPermission

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Story - An user story LPS-30382 Make upgrade processes run without aop logic

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Story - An user story LPS-30570 Move ServiceBuilder Index Creation into a util class

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Story - An user story LPS-30511 Duplicate code in UpgradeProcess and VerifyProcess

  • Trivial - Cosmetic problem like misspelt words or misaligned text.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates

Story - An user story LPS-30570 Move ServiceBuilder Index Creation into a util class

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Story - An user story LPS-30511 Duplicate code in UpgradeProcess and VerifyProcess

  • Trivial - Cosmetic problem like misspelt words or misaligned text.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
James Lefeu added a comment -

Upon discussion with Angelo Jefferson, this code update will not go in trunk, but will go in 6.1.x after which, it will be backported to 6.1.20 for a customer.

Show
James Lefeu added a comment - Upon discussion with Angelo Jefferson, this code update will not go in trunk, but will go in 6.1.x after which, it will be backported to 6.1.20 for a customer.
Hide
Permalink
James Lefeu added a comment -

Importing code from LPP-4193 debugging (6.1.20) and testing on 6.1.x before I send out a pull request review.

Show
James Lefeu added a comment - Importing code from LPP-4193 debugging (6.1.20) and testing on 6.1.x before I send out a pull request review.
Hide
Permalink
Michael Saechang added a comment -

Committed on:
Portal 6.2.x GIT ID: 1af31e6c386615cd2c4fdf3587f8debf195d5232.

Show
Michael Saechang added a comment - Committed on: Portal 6.2.x GIT ID: 1af31e6c386615cd2c4fdf3587f8debf195d5232.
Hide
Permalink
Ginson Ren added a comment -

Close this ticket since we passed LPS-31099.

Show
Ginson Ren added a comment - Close this ticket since we passed LPS-31099.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
    Days since last comment:
    25 weeks, 6 days ago

Time Tracking

Estimated:
Not Specified
Original Estimate - Not Specified
Remaining:
0m
Remaining Estimate - 0 minutes
Logged:
3d 15h
Time Spent - 3 days, 15 hours