PUBLIC - Liferay Portal Community Edition

Declare support for JBoss hot deploy when using ServerDetector.isSupportsHotDeploy() API

Details

  • Similar Issues:
    Show 5 results 

Description

the ServerDetector.isSupportsHotDeploy() API always returns false for JBoss app servers - however, as of 7.x I believe that it does support this (I am able to hot deploy plugins by copying them to Liferay's hot deploy directory).

I believe a new capabilities class needs to be implemented in the com.liferay.portal.server.capabilities package.

The problem with this is that on JBoss, Marketplace can't hot deploy downloaded apps, causing a degraded user experience. See LPS-29570.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Igor Spasic added a comment -

ServerDector (and ServerCapabilitiesUtil) just tries to detect if hot deploy feature is enabled on some app server. As on LPS-29792 we support JBoss 7.

For some application server we can determine if this feature is on or off. But for some app servers, we still can't be sure. For example, we can detect on startup that it is turned off; but there is some additional app server setting that turns it on. Moreover, some app server can change this setting in the runtime w/o restarting, and we check it only once, on portal startup.

Therefore, this flag is just a hint. It may not be 100% correct - especially when it says that hot deployment is not detected. This feature does not have any connection with the real process of deployment, and if something is failing it is not related to the isSupportsHotDeploy() flag.

For this reason I will close this issue.

Show
Igor Spasic added a comment - ServerDector (and ServerCapabilitiesUtil) just tries to detect if hot deploy feature is enabled on some app server. As on LPS-29792 we support JBoss 7. For some application server we can determine if this feature is on or off. But for some app servers, we still can't be sure. For example, we can detect on startup that it is turned off; but there is some additional app server setting that turns it on. Moreover, some app server can change this setting in the runtime w/o restarting, and we check it only once, on portal startup. Therefore, this flag is just a hint. It may not be 100% correct - especially when it says that hot deployment is not detected. This feature does not have any connection with the real process of deployment, and if something is failing it is not related to the isSupportsHotDeploy() flag. For this reason I will close this issue.
Hide
Permalink
James Falkner added a comment -

It's not a "will not fix" – you just fixed it with LPS-29792! So good work..

Show
James Falkner added a comment - It's not a "will not fix" – you just fixed it with LPS-29792 ! So good work..

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
    Days since last comment:
    26 weeks, 6 days ago