Details
-
Type:
Story
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 6.1.1 CE GA2, 6.1.20 EE GA2
-
Fix Version/s: 6.2.0 CE M2
-
Component/s: WCM, WCM > Localization
-
Epic/Theme:
-
Similar Issues:Show 4 results
LPS-27206Language Files (Properties) of a Hook are not undeployed correctly LPS-4248User profile update deletes Locale and Timezone if users.form.xxx properties are set LPS-230897Cogs: Displays 6.0 for 6.1 LPS-193116.0 & 6.1 - Improve the Persian language set
Description
Overview
Add Australian language properties, locale and timezones to Liferay Portal 6.0 and 6.1
Changes
Add Australian locale language properties
- Clone en_GB language properties file as en_AU (ie. Language_en_AU.properties)
Add Australian locale to portal properties
- Australian locale "en_AU" to "locales" properties in "portal.properties" file
locales=ar_SA,...,en_US,en_AU,en_GB,...,vi_VN (eg. locales=...,en_AU,...)
Add Australian flag icon to unstyled theme
- Add Australian flag icon to source folder "portal-web/docroot/html/themes/_unstyled/images/language/en_AU.png".
- Icon will be included in "Classic" theme and available for selection in "Language Portlet".
Add Australian capital cities and states to timezones in portal properties.
- Australian timezones (see Australian timezones supported by JVM)
#
# Specify the available time zones. The specified ids must match those from
# the class java.util.TimeZone.
#
time.zones=\
Pacific/Midway,\
...,\
Australia/ACT,\
Australia/Adelaide,\
Australia/Brisbane,\
Australia/Canberra,\
Australia/Darwin,\
Australia/Hobart,\
Australia/Melbourne,\
Australia/NSW,\
Australia/North,\
Australia/Perth,\
Australia/Queensland,\
Australia/South,\
Australia/Sydney,\
Australia/Tasmania,\
Australia/Victoria,\
Australia/West,\
...,\
Pacific/Kiritimati
Add Australian locale to I18n Servlet in web descriptor file "ROOT/WEB-INF/web.xml".
The following snippet shows how to add the Australian English (en_AU) as a new URL pattern.
<servlet-mapping> <servlet-name>I18n Servlet</servlet-name> <url-pattern>/en_AU/*</url-pattern> </servlet-mapping>
References
-
Hide
- LPS-28969-au-timezone-locale-patch-20120803T1557.zip
- 03/Aug/12 12:52 AM
- 198 kB
- Tim Telcik
-
- LPS-28969-au-timezone-locale-patch/.DS_Store 6 kB
- __MACOSX/.../._.DS_Store 0.1 kB
- LPS-28969-au-timezone-locale-patch/.../.DS_Store 6 kB
- __MACOSX/.../._.DS_Store 0.1 kB
- LPS-28969-au-timezone-locale-patch/.../.DS_Store 6 kB
- __MACOSX/.../._.DS_Store 0.1 kB
- LPS-28969-au-timezone-locale-patch/.../.DS_Store 6 kB
- __MACOSX/.../._.DS_Store 0.1 kB
- LPS-28969-au-timezone-locale-patch/.../.DS_Store 6 kB
- __MACOSX/.../._.DS_Store 0.1 kB
- LPS-28969-au-timezone-locale-patch/.../.DS_Store 6 kB
- __MACOSX/.../._.DS_Store 0.1 kB
- LPS-28969-au-timezone-locale-patch/.../.DS_Store 6 kB
- __MACOSX/.../._.DS_Store 0.1 kB
- LPS-28969-au-timezone-locale-patch/.../.DS_Store 6 kB
- __MACOSX/.../._.DS_Store 0.1 kB
- LPS-28969-au-timezone-locale-patch/.../.DS_Store 6 kB
- __MACOSX/.../._.DS_Store 0.1 kB
- LPS-28969-au-timezone-locale-patch/.../Language.properties 333 kB
- __MACOSX/.../._Language.properties 0.2 kB
- LPS-28969-au-timezone-locale-patch/.../Language_en_AU.properties 9 kB
- __MACOSX/.../._Language_en_AU.properties 0.2 kB
- LPS-28969-au-timezone-locale-patch/.../Language_en_GB.properties 9 kB
- __MACOSX/.../._Language_en_GB.properties 0.2 kB
- LPS-28969-au-timezone-locale-patch/.../portal.properties 300 kB
- __MACOSX/.../._portal.properties 0.2 kB
- LPS-28969-au-timezone-locale-patch/.../.DS_Store 6 kB
- __MACOSX/.../._.DS_Store 0.1 kB
- LPS-28969-au-timezone-locale-patch/.../.DS_Store 6 kB
- __MACOSX/.../._.DS_Store 0.1 kB
Activity
Hello Julio,
I have updated the details for this issue and attached a sample set of source/config files.
Let me know if you need anything else to test and commit these changes into the working branch, ready for LR 6.1 EE GA3 and related CE releases.
Regards,
Tim
Hi Tim,
I had a look at the Language_en_AU.properties that you uploaded and it doesn't seem correct. There are many keys which are exactly the same as in Language.properties and others have a wrong translation. For example, "Please enter a valid XML URL" is used as the translations for more than 60 keys, "My Pages" portlet has been renamed as "My Sites", "add Site Pages Variations" has been renamed as "add Page Variation" and the entity "User" has been translated as "Users and Organizations". I could understand that some of these may be personal preferences but we shouldn't change the default meaning of these keys just for one country.
This file should only contain those keys which are different to the ones in Language.properties because in Australia they are spelled different or different words are used to express the same. You can see an example in Language_en_GB.properties (e.g., color vs colour; Catalogue vs Catalog; Kilometre vs Kilometer and so on...)
Could you please upload a new version of this file and click on "Contribute Solution"? (I just need this file, don't worry about the others)
If your translation is exactly the same as Language_en_GB we could just leave this file empty and inherit from that one. what do you think?
Thank you Tim!
Hello Julio,
I uploaded another patch file set for Liferay Portal 6.1 EE GA1 (6.1.10), which contains the "Language_en_AU.properties" file.
It is possible I accidentally copied the base "Language_en_GB.properties" file from LR 6.0 EE, hence the difference between Community and Site in some labels.
The current edition of the "Language_en_AU.properties" file was copied from the "Language_en_GB.properties" file in Liferay Portal 6.1 EE GA1 (6.1.10). The files will be the same, as there are no obvious differences between the en_GB and en_AU locates for the current display text.
Please let me know if anything else seems amiss.
Regards,
Tim
Would be great to see this included in the next release. Anyone able to pick this up and add it?
Thank you Tim.
I have sent the pull-request to Brian including this Locale.
Thanks for your assistance, Julio.
I am sure plenty of Australian-based Liferay CE and EE customers will benefit from this enhancement in future releases.
Best Regards,
Tim
Committed on:
Portal 6.2.x GIT ID: 7698fae65df524e2ccf8a7e9298275a491a4c295.
PASSED Manual Testing using the following steps:
- Add the following line to portal-ext.properties file:
locales=en_AU
- Start up Liferay
- Navigate to Liferay.com and add a test page and a Language portlet to the test page
- Assert that the Australian flag displays in the Language portlet
- Add the Software Catalog portlet to the page, assert that Software Catalog is now spelled as "Software Catalogue"
- Navigate to My Private Pages
- Assert that the Australian flag displays in the Language portlet
- Navigate to My Public Pages
- Assert that the Australian flag displays in the Language portlet
- Navigate to the Control Panel > Users and Organizations
- Click on a user
- Click Display Settings and assert that the Language dropdown displays "English (Australia)"
- Assert that Software Catalog is now spelled as "Software Catalogue" on the left navigation panel
Reproduced on:
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 6372ab75da7ca5e9af787dc3d392bdae47e05063.
It seems as though the language settings have been successfully implemented for Australia, and that everything is working correctly across Private and Public Pages of a site and in the Control Panel.
Hey Tim,
regarding the Timezones, it seems that the portal has had these two for several versions:
Australia/Darwin,
Australia/Sydney,
We usually don't add all the existing timezones supported by the JVM in order not to clutter the UI with too many options, but just those which are different. In addition, people can add more or change the existing ones using this property: time.zones
Isn't this enough? Is there anything else you are missing?
Regarding the localization, that is totally fine. I think the en_AU won't have many differences with the en_US so we can probably follow the same approach as with en_GB which just overwrites the keys which are different. In order to do this, I would need you to contribute a first version of this file with some keys which are different from the en_US translation. Could you do that? You could just attach the file Language_en_AU.properties to this LPS including only some keys which differ from the Language.properties and then click on "Contribute Solution" (at the top). I would do the rest of the work (including the flag, properties... etc).
Thank you Tim!