PUBLIC - Liferay Portal Community Edition

JournalArticleContent.java: Include base exception within ArticleContentException

Details

  • Type: Feature Request Feature Request
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 6.1.10 EE GA1
  • Fix Version/s: None
  • Component/s: WCM, WCM > Web Content Administration
  • Labels:
    None
  • Similar Issues:
    Show 4 results 

Description

While working with Journal Articles, I found quite annoying and time consuming inonvenience. Method validateContent JournalArticleLocalServiceImpl looks like this:

	protected void validateContent(String content) throws PortalException {
		if (Validator.isNull(content)) {
			throw new ArticleContentException();
		}

		try {
			SAXReaderUtil.read(content);
		}
		catch (DocumentException de) {
			throw new ArticleContentException();
		}
	}

Everything works fine till DocumentException is thrown - it is not included within newly created ArticleContentException (it cost me 20 more minutes to find the cause of the problem).

I suggest replacing

		catch (DocumentException de) {
			throw new ArticleContentException();
		}

with

		catch (DocumentException de) {
			throw new ArticleContentException(de);
		}

Regards,
KG

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Krzysztof Gołębiowski added a comment -

Similar problem happens in class JournalContentImpl:

protected JournalArticleDisplay getArticleDisplay(
		long groupId, String articleId, String templateId, String viewMode,
		String languageId, int page, String xmlRequest,
		ThemeDisplay themeDisplay) {

		...
		
		catch (Exception e) {
			if (_log.isWarnEnabled()) {
				_log.warn(
					"Unable to get display for " + groupId + " " +
						articleId + " " + languageId);
			}

			return null;
		}
	}

Exception should be send as a parameter within "warn" method:

_log.warn(
					"Unable to get display for " + groupId + " " +
						articleId + " " + languageId, e);
Show
Krzysztof Gołębiowski added a comment - Similar problem happens in class JournalContentImpl: protected JournalArticleDisplay getArticleDisplay( long groupId, String articleId, String templateId, String viewMode, String languageId, int page, String xmlRequest, ThemeDisplay themeDisplay) { ... catch (Exception e) { if (_log.isWarnEnabled()) { _log.warn( "Unable to get display for " + groupId + " " + articleId + " " + languageId); } return null ; } } Exception should be send as a parameter within "warn" method: _log.warn( "Unable to get display for " + groupId + " " + articleId + " " + languageId, e);
Hide
Permalink
Krzysztof Gołębiowski added a comment -

Affected version is 6.1.0 CE GA1. I cannot change existing task so I post this info as comment.

Show
Krzysztof Gołębiowski added a comment - Affected version is 6.1.0 CE GA1. I cannot change existing task so I post this info as comment.
Hide
Permalink
Randy Zhu added a comment -

In preparation for Ideation; we are merging New Feature and Improvement tickets into a singular ticket type called “Feature Request”. Additional information to follow soon.

Show
Randy Zhu added a comment - In preparation for Ideation; we are merging New Feature and Improvement tickets into a singular ticket type called “Feature Request”. Additional information to follow soon.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Days since last comment:
    18 weeks ago