PUBLIC - Liferay Portal Community Edition

Cannot remove site in case it has link to page

Details

  • Branch Version/s:
    6.1.x
  • Backported to Branch:
    Committed
  • Epic/Theme:
  • Liferay Contributor's Agreement:
    Accept
  • Similar Issues:
    Show 5 results 

Description

To reproduce problem:
1. create site
2. create pages: page1, page2, page3
3. change type of page2 from "portlet" to link to page (for example to page3)
switch to control panel and try to remove this site: you will get error message (portlet is not available).
Stack trace:

13:14:09,790 ERROR [render_portlet_jsp:154] com.liferay.portal.LayoutTypeException
	at com.liferay.portal.service.impl.LayoutLocalServiceImpl.validateFirstLayout(LayoutLocalServiceImpl.java:2383)
	at com.liferay.portal.service.impl.LayoutLocalServiceImpl.deleteLayout(LayoutLocalServiceImpl.java:434)
	at com.liferay.portal.service.impl.LayoutLocalServiceStagingAdvice.deleteLayout(LayoutLocalServiceStagingAdvice.java:88)
	at com.liferay.portal.service.impl.LayoutLocalServiceStagingAdvice.invoke(LayoutLocalServiceStagingAdvice.java:108)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:112)
	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:71)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:108)
	at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:59)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:108)
	at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:59)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:108)
	at com.liferay.portal.spring.aop.ServiceBeanAopProxy.invoke(ServiceBeanAopProxy.java:211)
	at com.liferay.portal.service.impl.LayoutSetLocalServiceImpl.deleteLayoutSet(LayoutSetLocalServiceImpl.java:123)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:112)
	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:71)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:108)
	at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:59)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:108)
	at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:59)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:108)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Alexey Kakunin added a comment -

problem in fact what we remove pages (layouts) one by one from beginning - and in some moment link to page become to be first and validation failed.
To avoid this problem we can (for example) remove layouts from end to the begin - see attached version of LayoutSetLocalServiceImpl for details

Show
Alexey Kakunin added a comment - problem in fact what we remove pages (layouts) one by one from beginning - and in some moment link to page become to be first and validation failed. To avoid this problem we can (for example) remove layouts from end to the begin - see attached version of LayoutSetLocalServiceImpl for details
Hide
Permalink
Alexey Kakunin added a comment -

Version with fixed deleteLayoutSet method

Show
Alexey Kakunin added a comment - Version with fixed deleteLayoutSet method
Hide
Permalink
Igor Spasic added a comment -

Hello Alexey, thank you for submitting the fix for this issue! Just one little change, we need to loop to and including 0; so all layouts are iterated Thanx!

Show
Igor Spasic added a comment - Hello Alexey, thank you for submitting the fix for this issue! Just one little change, we need to loop to and including 0; so all layouts are iterated Thanx!
Hide
Permalink
Luyang Tan added a comment -

PASSED Manual Testing following the steps in the description.

Reproduced on:
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 3bf7da6efb3f17a72a81710e4ffcc8838deed348.

I can not remove the site.

Fixed on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 5508b31daae05330d8248d8837b19cfb84befe70.
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 056e411d55810eda3708816b8c6cae9a6f6947f5.

I can remove the site successfully.

Show
Luyang Tan added a comment - PASSED Manual Testing following the steps in the description. Reproduced on: Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 3bf7da6efb3f17a72a81710e4ffcc8838deed348. I can not remove the site. Fixed on: Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 5508b31daae05330d8248d8837b19cfb84befe70. Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 056e411d55810eda3708816b8c6cae9a6f6947f5. I can remove the site successfully.
Hide
Permalink
Edward Gonzales added a comment -

Slated for inclusion in 6.1.1 CE GA2

Show
Edward Gonzales added a comment - Slated for inclusion in 6.1.1 CE GA2

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
    Days since last comment:
    46 weeks, 4 days ago