FIREFOX - Media Gallery search field locks up when a user attempts to search twice

This seems to be a problem specific to Firefox, as reported under the tickets:

https://bugzilla.mozilla.org/show_bug.cgi?id=439810
https://bugzilla.mozilla.org/show_bug.cgi?id=443289

A recommended solution can be found here:

http://duckranger.com/2012/01/double-submit-prevention-disabled-buttons-firefox-and-the-back-button/

which makes use of the page show event (https://developer.mozilla.org/en/Using_Firefox_1.5_caching#pageshow_event).

This is reproducible in any of the search forms (Blogs, D&M, Media Gallery, Wiki, etc.) because they all use the same method to disable buttons from allowing double submits.

It looks like it's not a problem with caching at all. Rather, when the button is clicked, "disable" is added to the element, which makes it not clickable. When you press the back button in Firefox, the page is reloaded with the button in the state it was in after being clicked, thus disabled.

Our best idea for fixing this problem would be to check if the element is "disabled" and then have "disabled" removed. Is this the best way to go about it? Would this cause problems in other parts of Liferay?

Evan,

I think this is my point. As in, we always set buttons to "disabled" because we don't want to have a double submission for any forms. The difference is that when you hit the back button, on Firefox, it loads the page from its cache (which has stored in it a version of the HTML where the button is "disabled"). This is due to what is known by some as the Back-Forward Cache.

The solution that was recommended in the blog post was to use onpageshow (as opposed to onload) for Firefox to remove the "disabled". This seems to be confirmed in Mozilla's documentation about the page show event.

In my testing, it appears that the page is not loading from the bfcache, as the event pageshow is fired but the event.persisted always comes back as false.

Also, AUI's ready event fires on each page view and the method _bindForm() in form.js is called each time. This method is responsible for adding the submit event listener to the <form>. The event listener is added on each page view.

The issue appears to be that during A.bind(), the instance + method is valid the first time, but not went the back button is used. _onValidatorSubmit() is never called when [Submit] is clicked, after the back button is used.

formValidator.on('submit', A.bind('_onValidatorSubmit', instance));

I don't understand why this is.

Reproduced on:
Tomcat 7 + MySQL 5. Portal 6.1.x EE GIT ID: 60f589b832cb1368b7cf98a52f1e8979d9dc8266.
Tomcat 7 + MySQL 5. Portal 6.2.x GIT ID: 09d3044ba76fdf18456b163d7950bed1e4fa64b1.

PASSED Manual Testing following the steps in the description.

Reproduced on:
Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2.

Media Gallery search does not work when attempting to search twice.

Fixed on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 8534bc32bfd6cdda46cb1f119ccda49431b180f3.
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: b72be66fa9818d6f1b3d3f525f929f55a4c6f4c1.

Media Gallery search works properly.

FAILED Manual Testing following the steps in the description.

Failed on:
Tomcat 6.0 + MySQL 5. Portal 6.0.x GIT ID: 270ce199040719e9c31ff549934d7a7f3c518fd9.

Image Gallery search does not work when pressing Firefox's Back button and researching images.

PASSED Manual Testing following the steps in the description.

Fixed on:
Tomcat 6.0 + MySQL 5. Portal 6.0.x GIT ID: 68d85307c488a6d31f79d93791ae7ea750833181.

Image Gallery search works properly.