Liferay Issues

  • Log In Access more options
    • Online Help
    • GreenHopper Help
    • Agile Answers
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What’s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • Agile Access more options (Alt+g)
  • Test Sessions Access more options
    • Getting Started
PUBLIC - Liferay Portal Community Edition
  • PUBLIC - Liferay Portal Community Edition
  • LPS-34373 Display date can be set before the cr...
  • LPS-26221

Alarms/Announcements are not sent if display date is in the past

  • Agile Board
  • More Actions
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 6.1.0 CE GA1, 6.1.1 CE GA2, 6.1.20 EE GA2
  • Fix Version/s: 6.1.X EE, 6.2.0 CE M5
  • Component/s: Collaboration, Collaboration > Announcements
  • Labels:
    • QA-B
    • QA-R
    • QA-TP
    • ee-ts
    • usability
  • Environment:
    Jboss 7.1, Liferay 6.1.ga CE
  • Branch Version/s:
    6.1.x
  • Backported to Branch:
    Committed
  • Story Points:
    6
  • Business Value:
    4
  • Similar Issues:
    Show 5 results 

    LPS-26224Alarms/Announcements are being sent twice
    LPS-28630Past publication date and future publication date of announcements are not working correctly
    LPS-34373Display date can be set before the creation date
    LPS-6454Selenium - Web Content List portlet display articles before the display date
    LPS-14617The past tense of split is split

Description

Announcements are not sent if display date is in the past and announcement check interval passes while creating the announcement.

This can be achieved by setting announcements.entry.check.interval=1 and creating announcement and waiting 1 minute before hitting save. This happens because display date is set to "current time" when entry is started being edited and if announcements entry check happens before user saves the entry it will not get sent (if user does not alter the display date manually).

Issue Links

testing discovered

Bug - A problem which impairs or prevents the functions of the product. LPS-35628 Time doesn't get update when selecting other time zone in display settings.

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
  • Transitions Summary
  • Commits
Hide
Permalink
David Kubitza added a comment - 27/Mar/13 1:07 AM

Whenever display date < now - interval there are no notification emails sent out. I found this code which seems to be the reason:
https://github.com/liferay/liferay-portal/blob/master/portal-impl/src/com/liferay/portlet/announcements/service/impl/AnnouncementsEntryLocalServiceImpl.java#L130

As this is current master trunk it also affects Liferay 6.2.X.

In line 134 (https://github.com/liferay/liferay-portal/blob/master/portal-impl/src/com/liferay/portlet/announcements/service/impl/AnnouncementsEntryLocalServiceImpl.java#L134) it fetches announcements by display date which is clearly wrong because the user can manipulate the display date in any kind. Here you need to use the creation date of the announcement, as it can't be changed by the user. The modification date would also be an option, if notifications should also be send after a change of an existing announcement.

Show
David Kubitza added a comment - 27/Mar/13 1:07 AM Whenever display date < now - interval there are no notification emails sent out. I found this code which seems to be the reason: https://github.com/liferay/liferay-portal/blob/master/portal-impl/src/com/liferay/portlet/announcements/service/impl/AnnouncementsEntryLocalServiceImpl.java#L130 As this is current master trunk it also affects Liferay 6.2.X. In line 134 ( https://github.com/liferay/liferay-portal/blob/master/portal-impl/src/com/liferay/portlet/announcements/service/impl/AnnouncementsEntryLocalServiceImpl.java#L134 ) it fetches announcements by display date which is clearly wrong because the user can manipulate the display date in any kind. Here you need to use the creation date of the announcement, as it can't be changed by the user. The modification date would also be an option, if notifications should also be send after a change of an existing announcement.
Hide
Permalink
Serena Song added a comment - 27/May/13 2:02 AM

Blocked by LPS-35628

Show
Serena Song added a comment - 27/May/13 2:02 AM Blocked by LPS-35628
Hide
Permalink
Serena Song added a comment - 27/May/13 10:31 PM - edited

PASSED Manual Testing using the following steps:

  1. Open portal-ext.properties, add announcements.entry.check.interval=1 and following to the file :
        announcements.email.from.name=liferay.qa1
        announcements.email.from.address=liferay.qa1@gmail.com
    
        announcements.email.to.name=liferay.qa2
        announcements.email.to.address=liferay.qa2@gmail.com
    
        announcements.email.subject=com/liferay/portlet/announcements/dependencies/email_subject.tmpl
        announcements.email.body=com/liferay/portlet/announcements/dependencies/email_body.tmpl
    
  2. Login an Admin user
  3. Click My Account and click Display Setting
  4. Make sure that Admin user is set to the correct Time zone under Display Setting category matching the time zone on your computer.
  5. Click Announcements under Miscellaneous.
  6. Select all the email option and save.
  7. Go to control panel and set up mail server in the Server Administration.
  8. Back to liferay.com and add Announcement portlet to a page
  9. Click on "Manage Entries" tab.
  10. Click on "Add Entry" button.
  11. Verify that Display Date displays current time (the same as your computer).
  12. Populate Title field and Content section.
  13. Waiting 1 minute and then click on Save button.

Reproduced on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x 6.1.20 EE GA2.

Alarms/Announcements are not sent if display date is in the past.

Fixed on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 4b656be2d9b9bba35f13bec9304ba1eeb291a73d.
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 3decc66ba8f797d0e63c1fd82f74e2ff854fb753.

You can receive a notification email.

Show
Serena Song added a comment - 27/May/13 10:31 PM - edited PASSED Manual Testing using the following steps: Open portal-ext.properties, add announcements.entry.check.interval=1 and following to the file : announcements.email.from.name=liferay.qa1 announcements.email.from.address=liferay.qa1@gmail.com announcements.email.to.name=liferay.qa2 announcements.email.to.address=liferay.qa2@gmail.com announcements.email.subject=com/liferay/portlet/announcements/dependencies/email_subject.tmpl announcements.email.body=com/liferay/portlet/announcements/dependencies/email_body.tmpl Login an Admin user Click My Account and click Display Setting Make sure that Admin user is set to the correct Time zone under Display Setting category matching the time zone on your computer. Click Announcements under Miscellaneous. Select all the email option and save. Go to control panel and set up mail server in the Server Administration. Back to liferay.com and add Announcement portlet to a page Click on "Manage Entries" tab. Click on "Add Entry" button. Verify that Display Date displays current time (the same as your computer). Populate Title field and Content section. Waiting 1 minute and then click on Save button. Reproduced on: Tomcat 7.0 + MySQL 5. Portal 6.1.x 6.1.20 EE GA2. Alarms/Announcements are not sent if display date is in the past. Fixed on: Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 4b656be2d9b9bba35f13bec9304ba1eeb291a73d. Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 3decc66ba8f797d0e63c1fd82f74e2ff854fb753. You can receive a notification email.

People

  • Assignee:
    Serena Song
    Reporter:
    Samuli Saarinen
    Participants of an Issue:
    David Kubitza, Samuli Saarinen, Serena Song
Vote (0)
Watch (3)

Dates

  • Created:
    22/Mar/12 4:58 AM
    Updated:
    28/May/13 7:29 PM
    Resolved:
    23/Apr/13 9:24 PM
    Days since last comment:
    3 weeks, 1 day ago

Agile

  • View on Board
  • Atlassian JIRA (v5.2.11#854-sha1:ef00d61)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Liferay. Try JIRA - bug tracking software for your team.