PUBLIC - Liferay Portal Community Edition

Unable to retrieve the journal articles using JournalContentUtil class

Details

  • Branch Version/s:
    6.1.x
  • Backported to Branch:
    Committed
  • Fix Priority:
    4
  • Similar Issues:
    Show 5 results 

Description

I am trying to fetch the journal articles using $journalContentUtil variable in velocity.
1. Created two web contents Webcontent1 with default structure, Webcontent2 with user defined structure and templates.
2. Tried to retrieve the Webcontent1 using $journalContentUtil.getContent(10180, '11007', 'view', $themeDisplay.language-id, $xmlrequest) from the template of Webcontent2 and succeeded.

3. Created two web contents Webcontent3,Webcontent4 with two different structures and templates.
4. Tried to retrieve Webcontent3 using $journalContentUtil from the template of Webcontent4 but failed
5. Tried using various overloaded getContent methods in JournalContentUtil class still unable to fetch the article.
6. Also tried fetching the article in JSP but it is returning null.

Note: The templates are included in the web content by parsing VM file in the theme. It is working fine in liferay6.0 CE

Issue Links

causes

Sub-Task - The sub-task of the issue LPS-35031 Fix for 6.1: $groupId and @group_id@ value in WCM templates should always refer to the article groupId

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates

Bug - A problem which impairs or prevents the functions of the product. LPS-34140 Unable to retrieve the journal articles using JournalContentUtil class

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
rajesh added a comment -

This is a valid issue in liferay 6.1 CE, the problem is when JournalContentUtil.getContent() method is called

public static String getContent(long groupId,String articleId,String viewMode,String languageId,ThemeDisplay themeDisplay)

it check whether the article is template driven(if any template is associated with that article), then it called the transformer, it identifies the type of script and calls the respective parserEngine(VelocityTemplateParser)

The populateTemplateContext(TemplateContext tempcontext) method is called, which in turn calls the populateTemplateContext() method of super class BaseTemplateParser

The piece of code the where the problem occurs is populateTemplateContext of BaseTemplateParser.java

protected void populateTemplateContext(TemplateContext templateContext)
throws Exception {

templateContext.put("company", getCompany());
templateContext.put("companyId", getCompanyId());
templateContext.put("device", _themeDisplay.getDevice()); // _themeDisplay object is not initialized, therefore gives null pointer exception

Show
rajesh added a comment - This is a valid issue in liferay 6.1 CE, the problem is when JournalContentUtil.getContent() method is called public static String getContent(long groupId,String articleId,String viewMode,String languageId,ThemeDisplay themeDisplay) it check whether the article is template driven(if any template is associated with that article), then it called the transformer, it identifies the type of script and calls the respective parserEngine(VelocityTemplateParser) The populateTemplateContext(TemplateContext tempcontext) method is called, which in turn calls the populateTemplateContext() method of super class BaseTemplateParser The piece of code the where the problem occurs is populateTemplateContext of BaseTemplateParser.java protected void populateTemplateContext(TemplateContext templateContext) throws Exception { templateContext.put("company", getCompany()); templateContext.put("companyId", getCompanyId()); templateContext.put("device", _themeDisplay.getDevice()); // _themeDisplay object is not initialized, therefore gives null pointer exception
Hide
Permalink
rajesh added a comment -

I have replicated this issue in my local, and I will try to fix this issue.

Show
rajesh added a comment - I have replicated this issue in my local, and I will try to fix this issue.
Hide
Permalink
rajesh added a comment -

I would like to fix this issue and contribute the patch, please assign me this issue.

Show
rajesh added a comment - I would like to fix this issue and contribute the patch, please assign me this issue.
Hide
Permalink
Miguel Angel Júlvez added a comment -

Any update about this issue?

Show
Miguel Angel Júlvez added a comment - Any update about this issue?
Hide
Permalink
Miguel Angel Júlvez added a comment -

I can't believe this issue is not fixed yet. It was reported 5 months ago and it's really critical

Show
Miguel Angel Júlvez added a comment - I can't believe this issue is not fixed yet. It was reported 5 months ago and it's really critical
Hide
Permalink
Alberto Chaparro added a comment -

https://github.com/juanferrub/liferay-portal/pull/307

Show
Alberto Chaparro added a comment - https://github.com/juanferrub/liferay-portal/pull/307
Hide
Permalink
Michael Saechang added a comment -

Committed on:
Portal 6.2.x GIT ID: 3dd2fa697f895fb55faf0af4c9776ae9a9ec5899.

Show
Michael Saechang added a comment - Committed on: Portal 6.2.x GIT ID: 3dd2fa697f895fb55faf0af4c9776ae9a9ec5899.
Hide
Permalink
Pani Gui added a comment -

FAILED Manual Testing following the steps in the description.

Reproduced on:
Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2.

Using JournalContentUtil class to retrieve web contents fails.

Failed on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 2f2bc94e936de7a4865255d25ba7516c5406fc5b.
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 218a1b749c2f250969826c8a42e6b72aba951fd4.

I used $journalContentUtil.getContent(10180, '11403', $viewMode, $request.theme-display.language-id, '') to retrieve web contents.
When retrieving a web content with a structure and a template using the class from another template of a web content, it's still failed.
If retrieving a web content with no structure and no template, it's successful.

Show
Pani Gui added a comment - FAILED Manual Testing following the steps in the description. Reproduced on: Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2. Using JournalContentUtil class to retrieve web contents fails. Failed on: Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 2f2bc94e936de7a4865255d25ba7516c5406fc5b. Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 218a1b749c2f250969826c8a42e6b72aba951fd4. I used $journalContentUtil.getContent(10180, '11403', $viewMode, $request.theme-display.language-id, '') to retrieve web contents. When retrieving a web content with a structure and a template using the class from another template of a web content, it's still failed. If retrieving a web content with no structure and no template, it's successful.
Hide
Permalink
Jose Jimenez added a comment -

I tested with the next call and works fine:

$journalContentUtil.getContent( 10180, '10440', $viewMode, $request.theme-display.language-id , $xmlRequest )

Can you test another time replacing '10440' by your articleId and the last parameter by $xmlRequest?

Thanks

Show
Jose Jimenez added a comment - I tested with the next call and works fine: $journalContentUtil.getContent( 10180, '10440', $viewMode, $request.theme-display.language-id , $xmlRequest ) Can you test another time replacing '10440' by your articleId and the last parameter by $xmlRequest? Thanks
Hide
Permalink
Pani Gui added a comment -

PASSED Manual Testing following the steps in the description.

Reproduced on:
Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2.

Unable to retrieve web contents using JournalContentUtil class.

Fixed on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 1ba4fa3e1e3eb263d0ddb21a4839b7deac69f32d.
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: b9746b127bac28c75285cf306123a744af056fd4.

JournalContentUtil class works properly. Web contents are able to be retrieved to another web contents.

Show
Pani Gui added a comment - PASSED Manual Testing following the steps in the description. Reproduced on: Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2. Unable to retrieve web contents using JournalContentUtil class. Fixed on: Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 1ba4fa3e1e3eb263d0ddb21a4839b7deac69f32d. Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: b9746b127bac28c75285cf306123a744af056fd4. JournalContentUtil class works properly. Web contents are able to be retrieved to another web contents.
Hide
Permalink
Michael Saechang added a comment -

Thank you Pani for testing. Closing as 'Fixed'.

Show
Michael Saechang added a comment - Thank you Pani for testing. Closing as 'Fixed'.

People

Vote (4)
Watch (7)

Dates

  • Created:
    Updated:
    Resolved:
    Days since last comment:
    34 weeks ago