PUBLIC - Liferay Portal Community Edition

VelocityUtil.evaluate() creates velocity.log in tomcat bin directory

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 6.0.6 GA
  • Fix Version/s: --Sprint 12/11, 6.1.0 CE RC1
  • Component/s: Upgrades
  • Labels:
    None
  • Environment:
    Linux, Apache Tomat
  • Liferay Contributor's Agreement:
    Accept
  • Similar Issues:
    Show 5 results 

Description

com.liferay.portal.velocity.VelocityUtil.evaluate() (invoked in upgrade process) creates velocity.log in tomcat bin directory. It is not a good place for such file and in some environments portal may not have permissions to create that file, which cases exception.

The upgrade process for 6.0.6 is going well without velocity right now, but in the future, if someone will use velocity in some sql, there will be problem with upgrade.

It is described here also: http://www.liferay.com/community/forums/-/message_boards/message/7546271

  2. Text File
    VelocityUtil-r64895.reverse.patch
    25/May/11 2:19 PM
    2 kB
    Rafał Piotrowski

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Rafał Piotrowski added a comment -

This issue is a backlog candidate for the 100 PaperCuts program. Please consider participating! See http://liferay.com/community/100-papercuts

Show
Rafał Piotrowski added a comment - This issue is a backlog candidate for the 100 PaperCuts program. Please consider participating! See http://liferay.com/community/100-papercuts
Hide
Permalink
Milan Jaroš added a comment -

IMHO it creates velocity.log in working directory ($PWD).

Show
Milan Jaroš added a comment - IMHO it creates velocity.log in working directory ($PWD).
Hide
Permalink
Rafał Piotrowski added a comment -

Yes, you are right I start tomcat from it's bin directory, that's why I get velocity.log there

Show
Rafał Piotrowski added a comment - Yes, you are right I start tomcat from it's bin directory, that's why I get velocity.log there
Hide
Permalink
Rafał Piotrowski added a comment -

I think this file should not be created at all, all log from velocity should go to application log (via log4j).

Show
Rafał Piotrowski added a comment - I think this file should not be created at all, all log from velocity should go to application log (via log4j).
Hide
Permalink
Rafał Piotrowski added a comment -

It is already fixed by connor.mckay in commit 57916 in liferay trunk.

Show
Rafał Piotrowski added a comment - It is already fixed by connor.mckay in commit 57916 in liferay trunk.
Hide
Permalink
Milan Jaroš added a comment -

I can't find the fix you mentioned. Look into attached patch for revision 57916 by connor.mckay there are many fixes of comments but not velocity.log solution. Can you share the correct changeset? I'm interested in it.

Show
Milan Jaroš added a comment - I can't find the fix you mentioned. Look into attached patch for revision 57916 by connor.mckay there are many fixes of comments but not velocity.log solution. Can you share the correct changeset? I'm interested in it.
Hide
Permalink
Rafał Piotrowski added a comment -

Sorry, my mistake. It was fixed by brian.chan in commit 64895. In the attachment is reverse diff with changes in VelocityUtil.java that have fixed the bug.

Show
Rafał Piotrowski added a comment - Sorry, my mistake. It was fixed by brian.chan in commit 64895. In the attachment is reverse diff with changes in VelocityUtil.java that have fixed the bug.
Hide
Permalink
Milan Jaroš added a comment -

This is it! Thank you very much.

Show
Milan Jaroš added a comment - This is it! Thank you very much.
Hide
Permalink
Artur Linhart (BC) added a comment -

If somebody wants to have a fast way for fixing it, then here
http://www.bcpraha.cz/c/document_library/get_file?uuid=60afd297-d4a5-4a87-b24b-9993c3eb5827&groupId=11845
can be found the source code and also class file compiled under JDK 1.6 32bit

Show
Artur Linhart (BC) added a comment - If somebody wants to have a fast way for fixing it, then here http://www.bcpraha.cz/c/document_library/get_file?uuid=60afd297-d4a5-4a87-b24b-9993c3eb5827&groupId=11845 can be found the source code and also class file compiled under JDK 1.6 32bit
Hide
Permalink
Artur Linhart (BC) added a comment -

The above fix bases on the pure Liferay 6.0.6 original source code version,

Show
Artur Linhart (BC) added a comment - The above fix bases on the pure Liferay 6.0.6 original source code version,
Hide
Permalink
Milan Jaroš added a comment -

Thanks for share, Arche.

Show
Milan Jaroš added a comment - Thanks for share, Arche.

People

Vote (2)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
    Days since last comment:
    1 year, 45 weeks, 5 days ago