PUBLIC - Liferay Portal Community Edition

org.json.JSONException: Null key logged at warning level

Details

  • Branch Version/s:
    6.1.x, 6.0.x
  • Backported to Branch:
    Committed
  • Story Points:
    4
  • Similar Issues:
    Show 5 results 

Description

If audit logging is turned on an unexpected warning with stacktrace is logged:

2011-02-18 13:24:41,052 [WARN ] [liferay/audit] com.liferay.portal.json.JSONObjectImpl - org.json.JSONException: Null key.
org.json.JSONException: Null key.
at org.json.JSONObject.put(JSONObject.java:977)
at com.liferay.portal.json.JSONObjectImpl.put(JSONObjectImpl.java:240)
at com.liferay.portal.kernel.audit.AuditMessage.toJSONObject(AuditMessage.java:255)
at com.liferay.portal.audit.service.impl.AuditEventLocalServiceImpl.addAuditEvent(AuditEventLocalServiceImpl.java:66)

The cause of the issue is located in the AuditMessage.java code on line 255 (part of the method public JSONObject toJSONObject() )

254 jsonObj.put(_CLIENT_IP, _clientIP);
255 jsonObj.put(_clientHost, _clientHost);
256 jsonObj.put(_MESSAGE, _message);

The key passed in _clientHost is incorrect. The correct key should be _CLIENT_HOST

This same code still exists in the current revision of the file: 69340, only on a different line
portal/trunk/portal-service/src/com/liferay/portal/kernel/audit/AuditMessage.java

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrius Kurtinaitis added a comment -

This affects also 6.1.20 EE. Very annoying bug with a straightforward fix. Please fix it.
Currently I just commented out the use of CSVLogMessageFormatter in audit-spring.xml, which is triggering the bug on every audit event...

Show
Andrius Kurtinaitis added a comment - This affects also 6.1.20 EE. Very annoying bug with a straightforward fix. Please fix it. Currently I just commented out the use of CSVLogMessageFormatter in audit-spring.xml, which is triggering the bug on every audit event...
Hide
Permalink
Yang Gao added a comment -

PASSED Manual Testing using the following steps:

1. Set the following properties in portal-ext.properties:
audit.message.com.liferay.portal.model.Layout.VIEW=true
com.liferay.portal.servlet.filters.audit.AuditFilter=true
2. Audit-portlet and Audit-hook plugins have been deployed.
3. User is logged in as test@liferay.com.

Fixed on:
Tomcat 6.0 + MySQL 5. Portal 6.0.x GIT ID: 0083579545f0623b716d014c4c76f0a74de55b16.
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: e2bed399a4375b34494593a40f5737dbe26c9f51.
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 2665eac6510d5a3900b9463dea77bb2a0d182ec9.

The console will not show warnings.

Show
Yang Gao added a comment - PASSED Manual Testing using the following steps: 1. Set the following properties in portal-ext.properties: audit.message.com.liferay.portal.model.Layout.VIEW=true com.liferay.portal.servlet.filters.audit.AuditFilter=true 2. Audit-portlet and Audit-hook plugins have been deployed. 3. User is logged in as test@liferay.com. Fixed on: Tomcat 6.0 + MySQL 5. Portal 6.0.x GIT ID: 0083579545f0623b716d014c4c76f0a74de55b16. Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: e2bed399a4375b34494593a40f5737dbe26c9f51. Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 2665eac6510d5a3900b9463dea77bb2a0d182ec9. The console will not show warnings.

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
    Days since last comment:
    7 weeks, 3 days ago