PUBLIC - Liferay Portal Community Edition

Create a status column in user to allow workflow for user creation

Details

  • Similar Issues:
    Show 4 results 

Description

We will create a new status column in the User_ table that will allow workflow for user creation.
Right now, there is "active_" column that defines if a user is active or not. This column will be eliminated and will be handled as a status within the new column.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Sergio Gonzalez added a comment -

This feature will also be used when creating fast anonymous account, that will remain in the STATE_INCOMPLETE status

Show
Sergio Gonzalez added a comment - This feature will also be used when creating fast anonymous account, that will remain in the STATE_INCOMPLETE status
Hide
Permalink
Brian Chan added a comment -

Hey Sergio,

Please see rev 72030 and 72033 for /portal/trunk

1.) WorkflowConstants.STATUS_* should each have a unique value.

2.) sql update file should use FALSE and not 0 since that is db specific. Others use "t" vs "f" or something. See BaseDB and *DB.java. We will translate FALSE to the db specific value at runtime.

3.) UserIndexer needs to check for null value for "status" or else the auto boxing will break (conversion from int to Integer assumes non null)

4.) Everything else was source formatting

Great job on the checkin

Show
Brian Chan added a comment - Hey Sergio, Please see rev 72030 and 72033 for /portal/trunk 1.) WorkflowConstants.STATUS_* should each have a unique value. 2.) sql update file should use FALSE and not 0 since that is db specific. Others use "t" vs "f" or something. See BaseDB and *DB.java. We will translate FALSE to the db specific value at runtime. 3.) UserIndexer needs to check for null value for "status" or else the auto boxing will break (conversion from int to Integer assumes non null) 4.) Everything else was source formatting Great job on the checkin
Hide
Permalink
Sergio Gonzalez added a comment -

Hi Ben,

I think that there is no need to do a manual test for this. This is a feature that is required for another tickets (user workflow, anonymos comments).
Then, I think that you should do the tests for these other tickets, but not for this ticket.

Let me know if you need any other info.

Thanks!
Sergio

Show
Sergio Gonzalez added a comment - Hi Ben, I think that there is no need to do a manual test for this. This is a feature that is required for another tickets (user workflow, anonymos comments). Then, I think that you should do the tests for these other tickets, but not for this ticket. Let me know if you need any other info. Thanks! Sergio
Hide
Permalink
Benjamin Yeh added a comment -

No manual cert needed

Show
Benjamin Yeh added a comment - No manual cert needed

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
    Days since last comment:
    2 years, 3 weeks ago