|
Thank you Nate.
Regarding the theme name, I encountered the same issues - it stripped out non-alphanumeric characters. I found a simple fix for a problem we talked about earlier - how the category background colors are "forgotten". e.g. click the Server portlet and then click Log Levels. I attached the fixed patch for you to review. -Peter Hi Nate,
Changing the theme name to "control_panel" works fine. Just change the folder name and the liferay-look-and-feel.xml file (also the build.xml file as well): <theme id="control_panel" name="Control Panel"> The issue I encountered before came up because I tried naming it "control-panel" On line 516 of ThemeLocalServiceImpl.java, it stripped out the dash from the theme-id. Underscores are not affected though so there should be no problem there for you. By the way, when the Control Panel theme was not registered, the Administration layout had no styles and it didn't look good. That's why I put a few of the css styles in css_cached.jsp. This way even if a user deletes the Control Panel theme, the Administration page would look okay (everyone will have the Administration page by default). I initially thought about putting the styles in the core _styled theme, but like you mentioned, the control panel styles are only being used on one jsp located in the portal folder and the existing convention was to put those styles in css_cached.jsp. -Peter This was committed to trunk a few days ago
|
||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
Sub-task
Closed
Minor
I've gone ahead and reviewed Peter's changes, and re-implemented a few things, and changed some stuff around.
Peter, just as an FYI, here's the main stuff:
I took all of the styling that was used for the lfr-ctrl-panel and placed it only in the control panel theme. This is the only theme that will have access to those pages, so that styling doesn't need to exist in css_cached.jsp or anywhere else.
I implemented the toggle menu, as well as persistence for the user.
I also implemented the sortable panels dragging via the handle, but I have NOT implemented the persistence for that piece. I'll need to coordinate with either bchan or Jorge on how to best persist the ordering.
I changed around the html in the menu a bit, and moved some styling around.
Also, I placed all of the images for the control panel in the _diffs/common. Since no other theme will need these images (since they won't be used on the control panel), they can sit in the common like we would do it on a normal theme.
Pending:
I still need to implement the drop down menu for the community navigation.
Persistence for the panel menu sorting
I wanted to change the name of the admin theme to control_panel, but I couldn't seem to get it to work. Peter, you mentioned that you tried a dash in teh name, are you able to get it to work with an underscore (which is our normal word-separator for filenames)?
Thanks all, and please let me know if there any issues with my commit.